Being a tranny person for some quarter of a century - and don't even think about misinterpreting that statement

- neither cropping nor any other facility was an option. You either got it right first time, or you wasted a shot.
Of course, when I got a PC and associated stuff, I scanned some prints and fiddled with them. But the original was never good enough.
Now, with the Digital camera as first choice, and the SLR relegated to special occasions, I crop almost as a matter of course. It's not a portrait vs. landscape thing, Kay, though clearly one format may suit a medium, as portrait suits POTW. It is just as valid, and often appropriate, to crop portrait to landscape, and for certain markets, cropping to square is required. Mostly, I only crop to remove unwanted peripheral detail. And I should have done that when firing off the shot in the first place.
But let's just keep it all in perspective. Imaging software is a useful tool. It is an excellent resource to have in your toolbox, but it will never make a poor photo good, or a good photo great.
Use your imaging software sparingly, to bring out the best in your photos. Don't fall into the image enhancement trap, which has seen the web flooded with over-enhanced, over-manipulated rubbish which the purveyors presumably see as art.
(Tirade over

)
Mike